gh-144270: make SubElement parent and tag positional-only#144845
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom Mar 30, 2026
Merged
gh-144270: make SubElement parent and tag positional-only#144845serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
d956c30 to
1551ff7
Compare
brijkapadia
reviewed
Feb 16, 2026
Member
|
You could also merge two PRs in one. |
The C accelerator implementations use PyArg_ParseTuple, which inherently enforces positional-only parameters. The Python fallback allowed these as keyword arguments, creating a behavioral mismatch. Make the tag parameter of Element.__init__ and the parent and tag parameters of SubElement positional-only to align with the C accelerator.
b9cacad to
38af9cf
Compare
Contributor
Author
Great. I've squashed the Element change from #144876 into this PR, you can close that one. |
…element-positional-only
serhiy-storchaka
approved these changes
Mar 30, 2026
Member
|
Merged. Thank you for your contribution, @NekoAsakura. |
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Mar 30, 2026
…ktor * upstream/main: (119 commits) pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845) pythongh-146558: JIT optimize dict access for objects with known hash (python#146559) pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570) pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631) pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593) pythongh-138122: Add differential flame graph (python#145785) pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417) pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628) pythongh-138850: Add --disable-epoll to configure (pythonGH-145768) pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624) pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597) pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557) pythongh-146579: _zstd: Fix decompression options dict error message (python#146577) pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085) pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573) pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569) pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472) pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580) pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004) pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #144270
Make
parentandtagpositional-only inxml.etree.ElementTree.SubElementto match the C accelerator.The C implementation (
_elementtree.SubElement) usesPyArg_ParseTuple, which inherently makesparentandtagpositional-only. The Python fallback useddef SubElement(parent, tag, attrib={}, **extra):which allowedparentandtagas keyword arguments. This inconsistency meantSubElement(parent=e, tag="x")worked only when the C accelerator was unavailable.Fix: add
/aftertag→def SubElement(parent, tag, /, attrib={}, **extra):Changes
Lib/xml/etree/ElementTree.py: add/toSubElementsignatureLib/test/test_xml_etree.py: addtest_subelementcovering positional-only enforcement, keyword attrib, and kwargs-as-XML-attributes parityDoc/library/xml.etree.elementtree.rst: update signature and addversionchanged:: 3.15Note
Element.__init__has the same Python/C signature mismatch —tagis positional-only in the C version (PyArg_ParseTupleat_elementtree.c:419) but accepts keywords in the Pythonfallback (
ElementTree.py:167). I will create a separate issue for that to keep this PR focused.cpython/Lib/xml/etree/ElementTree.py
Line 167 in 23c488d
cpython/Modules/_elementtree.c
Lines 419 to 420 in 23c488d
📚 Documentation preview 📚: https://cpython-previews--144845.org.readthedocs.build/